Fix location of intersect point for @turf/point-on-line. #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #691 and #722. A few issues to point out:
location
property of theintersectPt
was being computed using theclosestPt
which was initialized toInfinity
which yielded spurious results. I believe it should be computed usingintersectPt
.turf-point-on-line - points on top of line
uses a line with length0.30576
and places10
equally spaced points on it. So the first point should have been at0.030576
but the test was expecting it at0.021111
. Hence the fixtures have been updated accordingly.I checked the results and #691 and #722 appear to have been fixed. Could use a double check though.
Please fill in this template.
npm test
at the sub modules where changes have occurred.npm run lint
to ensure code style at the turf module level.