Add core tests - file management & package.json rules #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required files
- test.js
- bench.js
- index.js
- index.d.ts
- README.md
- types.ts (optional for now)
- invalid dependencies (should be used as devDependencies)
- tape
- benchmark
- eslint (handled at root level)
- strict version dependencies
- jsts (v1.3.0)
- duplicated dependencies (also included in devDependencies)
- check if `files` exists from package.json
- Confirm MIT license
- correct scoped name `@turf/module-name`
- Pre-defined attributes in package.json
- Parsing dependencies from `index.js`
- require('module') should be included in `dependencies` in package.json
- no duplicate `require` (ex: only require `@turf/helpers` once)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent with this PR is to keep the
package.jsonattributes & standard TurfJS files consistent.Here's a summary of the new
packages/turf/test.js:filesexists from package.json@turf/module-nameindex.jsdependenciesin package.jsonrequire(ex: only require@turf/helpersonce)