Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript declaration of @turf/points-within-polygon #1761

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

rugheid
Copy link
Contributor

@rugheid rugheid commented Sep 26, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
    The tests crash with me locally, but I tried linking the package to the project I'm working on and the types work.
  • Run npm run lint to ensure code style at the turf module level.
    Lint also doesn't work for me locally, but it should be ok I guess.

This PR improves the TypeScript declaration for points-within-polygon to make sure the output points contain the same GeoJSON properties as the input points.

Copy link
Collaborator

@mfedderly mfedderly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mfedderly mfedderly merged commit c21060e into Turfjs:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants