Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the Typescript defs for turf.voronoi. #1424

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Conversation

stevage
Copy link
Collaborator

@stevage stevage commented Jun 24, 2018

Fixes #1422.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

@chansen-va chansen-va mentioned this pull request Feb 6, 2019
2 tasks
@Naitik333
Copy link

Can any one please merge Pull request, its open from Jun 24, 2018. Its stopping us from using turfJs voronoi in typescript environment.

Copy link
Collaborator

@mfedderly mfedderly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is a breaking change but it is also just wrong on master so lets get it merged to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@turf/voronoi not typed correctly
4 participants