Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Limit Glide cache to 200 MB #381

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Conversation

msfjarvis
Copy link
Collaborator

Gonna take a while to see if it truly works so letting this be a draft for now

@AbsurdlySuspicious
Copy link
Collaborator

root@localhost /d/d/m/cache# du -hd 1 | sort -h
212K    ./disk_lru_cache
22M     ./WebView
202M    ./image_manager_disk_cache
224M    .
root@localhost /d/d/m/cache# du -hd 1 | sort -h
212K    ./disk_lru_cache
22M     ./WebView
201M    ./image_manager_disk_cache
223M    .

I scrolled the feed and downloaded some pretty large images between these two du invocations so this works good

@AbsurdlySuspicious
Copy link
Collaborator

Maybe there's also some sense in making this limit configurable. This is surely matter of another PR though

Fixes Tunous#353

Signed-off-by: Harsh Shandilya <[email protected]>
@msfjarvis msfjarvis marked this pull request as ready for review February 1, 2021 13:15
@msfjarvis msfjarvis enabled auto-merge (squash) February 1, 2021 13:15
@msfjarvis msfjarvis merged commit f9403ad into Tunous:master Feb 1, 2021
@msfjarvis msfjarvis deleted the cache-size-limit branch February 1, 2021 13:19
@msfjarvis msfjarvis added this to the 0.12.3 milestone Feb 1, 2021
@msfjarvis msfjarvis added the code Pull requests that make code only related changes label Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code Pull requests that make code only related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants