Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Inline text selection #177

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Inline text selection #177

merged 2 commits into from
Apr 29, 2020

Conversation

AbsurdlySuspicious
Copy link
Collaborator

@AbsurdlySuspicious AbsurdlySuspicious commented Apr 28, 2020 •
edited
Loading

My attempt on making inline text selection:

dawn_sel_main
dawn_sel_md

  • Collapse, swipe actions, link longpress works
  • Collapsed comments can't be selected
  • Touch ripple works
  • Most of markdown blocks selects properly

Bugs:

  • Monospace markdown blocks have invisible selection (copy works, though)

@AbsurdlySuspicious
Copy link
Collaborator Author

Solves (replaces?) #89

@Tunous
Copy link
Owner

Tunous commented Apr 28, 2020 •
edited
Loading

Wow, great work! That is definitely better than my poor workaround with selection dialog 😁
I’ll test whether this works on my phone too.

Submission title selection
Submission text selection

I would suggest creating a separate pull request for these two since they are dealing with different interface elements.

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@saket
Copy link

saket commented Apr 28, 2020

nice!

@AbsurdlySuspicious
Copy link
Collaborator Author

AbsurdlySuspicious commented Apr 28, 2020 •
edited
Loading

I would suggest creating a separate pull request for these two since they are dealing with different interface elements.

fixed task list

@AbsurdlySuspicious
Copy link
Collaborator Author

AbsurdlySuspicious commented Apr 28, 2020 •
edited
Loading

Bug with monospace blocks appears with selftext selection too and probably needs to be solved separately as well, so I will undraft this

@AbsurdlySuspicious AbsurdlySuspicious marked this pull request as ready for review April 28, 2020 17:50
Tunous
Tunous suggested changes Apr 28, 2020
View reviewed changes
Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app has also SubmissionLocalComment for comments which are created locally by the user, displayed before they are synchronized. The code in them should be updated too.

@AbsurdlySuspicious
Copy link
Collaborator Author

Done

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@Tunous Tunous merged commit a3351be into Tunous:master Apr 29, 2020
@Tunous Tunous added the feature New feature label Apr 29, 2020
@Tunous Tunous added this to the 0.9.0 milestone Apr 29, 2020
@AbsurdlySuspicious AbsurdlySuspicious deleted the selection branch April 29, 2020 23:57
@AbsurdlySuspicious AbsurdlySuspicious mentioned this pull request May 1, 2020
Merged
@Tunous Tunous mentioned this pull request May 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tunous Tunous Tunous approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AbsurdlySuspicious @Tunous @tunous-bot @saket