Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor get operation #568

Merged
merged 2 commits into from
Jun 27, 2024
Merged

refactor get operation #568

merged 2 commits into from
Jun 27, 2024

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jun 26, 2024

Replace Operations()[operation] by GetOperation(operation) which is cheaper.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (c322a59) to head (2a6a585).

Files Patch % Lines
checker/check_api_removed.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   84.80%   85.59%   +0.79%     
==========================================
  Files         227      227              
  Lines       12963    10830    -2133     
==========================================
- Hits        10993     9270    -1723     
+ Misses       1563     1153     -410     
  Partials      407      407              
Flag Coverage Δ
unittests 85.59% <93.33%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 68ee79d into main Jun 27, 2024
16 checks passed
@reuvenharrison reuvenharrison deleted the get_operation branch June 27, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant