Add users Gravatar on signup #1442
Conversation
|
You are totally right, removed as dependency. |
|
Lol! It was an honest question. I may have expressed incredulity but I would have been happy to receive an explanation of why it was better ;) Can you please rebase & clean up the extra commit? Thanks 👍 |
|
Lol, request is normally what I use for everything http related, its decent but doesn't warrant adding a dependency for 1 line. I'm a git beginner in terms of rebasing, I hope I got that right. Let me know if you wanted anything else doing / make any changes. |
| checkPromise = nodefn.call(http.get, gravatarUrl); | ||
|
|
||
| return checkPromise.then(function () { | ||
| //Error making request just continue. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
When a user registers try to find their gravatar.
|
Really like this approach of grabbing a gravatar on signup and then allowing it to be changed afterwards. Very nice :) |
|
Whoop this works really nicely because I can remove it if I don't want it. NEAT. |
When a user registers try to find their gravatar and use it if found, from there allow them to change it the normal way. #1421