Change the WAL journal mode back to the default DELETE mode #8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
approved these changes
May 23, 2024
kozlovsky
force-pushed
the
fix/use_default_journal_mode
branch
from
722f2f1
to
5c2800a
Compare
kozlovsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8035.
The WAL mode is persistent, so it is necessary to switch it to DELETE mode at least once (see https://www.sqlite.org/wal.html).
After that, it is not strictly necessary to execute
PRAGMA journal_mode = DELETEagain, but executing it is cheap and fast, and consistently executing it every time the connection is open avoids some potential future errors.