Add breadcrumb ordering #8034
Merged
Add breadcrumb ordering #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
feature/breadcrumbs_sort
branch
from
75f6da1
to
2f0ca7a
Compare
kozlovsky
requested changes
May 24, 2024
There was a problem hiding this comment.
Unfortunately, it does not work: https://sentry.tribler.org/organizations/tribler/issues/2658/events/e962cfb599ab49ddbf9f874d1720642d/
You can see that breadcrumbs still come in two independently sorted groups.
(As a side note, I noticed that the user comment is currently omitted from the Sentry report, even when included. It is not related to the current PR, I will investigate it)
|
You are right. It is strange. I'll investigate further. |
drew2a
force-pushed
the
feature/breadcrumbs_sort
branch
from
3e11817
to
957b329
Compare
|
@kozlovsky I think I've fixed it by 957b329 https://sentry.tribler.org/organizations/tribler/issues/2658 |
|
Nope, it is still two separate lists: https://sentry.tribler.org/organizations/tribler/issues/2658/events/0a59f86f4eeb4c908fd860e2da8343c0/ |
kozlovsky
approved these changes
May 27, 2024
drew2a
force-pushed
the
feature/breadcrumbs_sort
branch
from
959c520
to
562d45c
Compare
drew2a
force-pushed
the
feature/breadcrumbs_sort
branch
from
562d45c
to
76e4c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that breadcrumbs are not always sorted by timestamp:
This PR fixes it by Introducing a new feature to order breadcrumbs by timestamp in ascending order. This is achieved by adding a new function,
order_by_utc_time, which sorts the breadcrumbs based on their timestamps.Ref: