Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dependencies for application tester to run #7824

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Jan 15, 2024

While fixing the application tester jobs on Jenkins, I found that some dependencies need to be installed to run the application tester from the Tribler repo application tester code. This is a subset of Tribler dependencies.

@drew2a
Copy link
Collaborator

drew2a commented Jan 15, 2024

When I added the Application Tester to the GitHub actions, I assumed that the installed requirements from the main Tribler were sufficient for the Application Tester to run. Therefore, I removed the dedicated requirements.txt as I thought it was better to have fewer requirements.txt files :)

Don't forget to fix the https://github.com/Tribler/tribler/blob/main/.github/workflows/application_tester.yml if you think is necessary to have the dedicated requirements.txt.

P.S. Some dependencies look suspicious to me, but as it's currently in draft, I'll leave the review part to the reviewer.

@drew2a drew2a closed this Jan 15, 2024
@drew2a drew2a reopened this Jan 15, 2024
@xoriole xoriole changed the title Add dependencies for application tester to run [WIP] Add dependencies for application tester to run Jan 16, 2024
@xoriole xoriole marked this pull request as ready for review January 16, 2024 13:44
@xoriole xoriole requested a review from a team as a code owner January 16, 2024 13:44
@xoriole xoriole requested review from egbertbouman and removed request for a team January 16, 2024 13:44
@xoriole xoriole marked this pull request as draft January 16, 2024 14:08
@xoriole xoriole changed the base branch from main to temp/application-tester January 17, 2024 11:11
@xoriole xoriole marked this pull request as ready for review January 17, 2024 11:11
@xoriole xoriole force-pushed the fix/application-tester-dependencies branch from 14c5ce7 to 5f672b4 Compare January 17, 2024 12:11
@xoriole xoriole closed this Jan 17, 2024
@xoriole xoriole force-pushed the fix/application-tester-dependencies branch from 5f672b4 to 8ca3148 Compare January 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants