Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged Popularity, RemoteQuery and Version communities #7743

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Dec 1, 2023

Related to #7669

This PR merges the Popularity, RemoteQuery and Version communities into one ContentDiscoveryCommunity.


Codacy appears to no longer upload. On the site itself the results show a pass though:

screenshot

@qstokkink qstokkink force-pushed the upd_popcom_merge_rename branch 5 times, most recently from 1a97449 to cf066f5 Compare December 5, 2023 12:36
@qstokkink qstokkink marked this pull request as ready for review December 5, 2023 12:44
@qstokkink qstokkink requested a review from a team as a code owner December 5, 2023 12:44
@qstokkink qstokkink requested review from kozlovsky and removed request for a team December 5, 2023 12:44
@qstokkink qstokkink force-pushed the upd_popcom_merge_rename branch 2 times, most recently from 02d1149 to 8650e2b Compare December 5, 2023 13:36
@qstokkink qstokkink removed the request for review from kozlovsky December 5, 2023 13:36
@qstokkink
Copy link
Contributor Author

qstokkink commented Dec 5, 2023

I'll use a random number generator to select a reviewer from @Tribler/dev that is not on vacation. If you get assigned, it's nothing personal.

EDIT:

Python 3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from random import choice
>>> choice(["xoriole", "egbertbouman", "drew2a"])
'egbertbouman'
>>>

@qstokkink qstokkink changed the title WIP: Merged Popularity, RemoteQuery and Version communities READY: Merged Popularity, RemoteQuery and Version communities Dec 5, 2023
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming there are future plans to do something with the newly added send_ping.

Other than that, it looks good to me.

@qstokkink qstokkink changed the title READY: Merged Popularity, RemoteQuery and Version communities Merged Popularity, RemoteQuery and Version communities Dec 6, 2023
@qstokkink qstokkink merged commit b15b079 into Tribler:main Dec 6, 2023
16 of 17 checks passed
@qstokkink qstokkink deleted the upd_popcom_merge_rename branch December 6, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants