Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Python 3.11 Support #7448

Closed
wants to merge 1 commit into from

Conversation

InvictusRMC
Copy link
Member

@InvictusRMC InvictusRMC commented May 31, 2023

This PR updates dependencies for Python 3.11 support (#7282). This PR depends on unmerged changes and, as such, is not ready to be merged. In summary, I applied the following dependency changes for 3.11 to function (on Apple Silicon):

@InvictusRMC InvictusRMC added the dependencies Pull requests that update a dependency file label May 31, 2023
@InvictusRMC InvictusRMC requested a review from a team as a code owner May 31, 2023 09:48
@InvictusRMC InvictusRMC requested review from xoriole and removed request for a team May 31, 2023 09:48
Copy link
Contributor

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see you managed to run Libtorrent (and Tribler partially) on Apple silicon 👍

For full Python 3.11 support, we'll likely need to wait sometime before all dependencies are working and installable via pypi.

bitarray==2.5.1
pyipv8==2.10.0
libtorrent==1.2.15
libtorrent==1.2.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libtorrent 1.2.19 is not yet available on pypi for Python3.11.
https://pypi.org/project/libtorrent/1.2.19/#files

@@ -2,6 +2,6 @@

Pillow==9.3.0
PyQt5==5.15.1
PyQt5-sip==12.8.1
PyQt5-sip==12.11.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While PyQt5-sip==12.11.1 does install well, PyQt5==5.15.1 errors on installation on Python 3.11 on my Apple silicon M2.

@InvictusRMC
Copy link
Member Author

Great to see you managed to run Libtorrent (and Tribler partially) on Apple silicon 👍

For full Python 3.11 support, we'll likely need to wait sometime before all dependencies are working and installable via pypi.

Acutally got Tribler working too. But currently requires building both Libtorrent and Pony from source. Am curious about your errors though

@InvictusRMC
Copy link
Member Author

Update: I found out that manually building LibTorrent 1.2.19 does the trick regardless.

@drew2a
Copy link
Collaborator

drew2a commented Jul 11, 2023

@InvictusRMC, following our recent update of dependencies, we now have libtorrent 1.2.19 listed in Tribler's requirements.

See: https://github.com/Tribler/tribler/pull/7529/files#diff-7bb1a497b3f7e9384c7441b71810dcc519b5bc5f8866f15f294fa0508d073318R26

@Solomon1732
Copy link
Contributor

Solomon1732 commented Jul 15, 2023

Update: I found out that manually building LibTorrent 1.2.19 does the trick regardless.

Relevant to LibTorrent: #7282 (comment). It may be worth working on its 2.0 branch? It's my humble suggestion since it's your PR and I know nothing of the work which goes into it

@qstokkink
Copy link
Contributor

The changes of this PR have been largely - with the exception of the PyQt5-sip requirement - already been implemented by other PRs.

The blocker for this PR is updating the libtorrent version, which is not currently part of this PR and is not actively WIP from our side. Therefore, I'll close this PR for now. We can rebase and reopen or recreate this PR later when an appropriate libtorrent version becomes available.

@qstokkink qstokkink closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants