Fix "error: unrecognized arguments"

[drew2a]

This PR fixes #6929

[drew2a]

@kozlovsky could you please confirm that it works on built windows?

[kozlovsky]

The fix is indeed working; I can confirm it on Windows. But I don't think this is the proper way to handle the issue. The proposed fix just ignores arguments that ArgsParser does not understand, and it may be error-prone. Like, if later GUI starts specifying new options when running Core, any typo in an argument will remain unnoticed, as Core will silently ignore unknown arguments.

I debugged the problem and found the reason for the error. It is in this line of CoreManager:

self.core_process.start(sys.executable, core_args)

There is a difference in arguments between a python script and a compiled executable. For script, arguments can look like

["myscript.py", "arg1", "arg2"]

and sys.executable is something like C:/Python39/python.exe.

For the same code in the compiled executable, arguments will be

["myscript.exe", "arg1", "arg2"]

and sys.executable is myscript.exe.

That means that when Tribler executes self.core_process.start(sys.executable, core_args) from the compiled binary, it runs tribler.exe with arguments ["tribler.exe", "some.torrent", "--core"], because tribler.exe comes both from sys.executable and from sys.argv[0]. The proper fix, in my opinion, is to remove duplicate "tribler.exe" from the argument list when running a code from compiled binary.

So, the reason for the error is that when compiled, GUI runs Core with arguments:

tribler.exe tribler.exe some.torrent --core

And the proposed fix ignores the last positional argument, interpreting the arguments as

tribler.exe tribler.exe --core

where the second "tribler.exe" is interpreted as a torrent file name, while the proper fix should ignore the first positional argument and not the last one. To remove the duplicate binary, we can do something like the following.

[drew2a]

The proper fix is here: #6937