Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing XML declaration #6703

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Fix missing XML declaration #6703

merged 2 commits into from
Jan 7, 2022

Conversation

overflw
Copy link
Contributor

@overflw overflw commented Jan 3, 2022

In update_version_from_git.py the current version is written into metainfo.xml. Unfortunately, the XML declaration is not generated after inserting the current version.

@overflw overflw requested a review from a team as a code owner January 3, 2022 22:25
@overflw overflw requested review from xoriole and removed request for a team January 3, 2022 22:25
@tribler-ci
Copy link
Contributor

Can one of the admins verify this patch?

@qstokkink
Copy link
Contributor

ok to test

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a merged commit 70e145c into Tribler:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants