Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Tribler logger #6585

Merged
merged 19 commits into from
Nov 26, 2021
Merged

Fixes for Tribler logger #6585

merged 19 commits into from
Nov 26, 2021

Conversation

kozlovsky
Copy link
Collaborator

This PR fixes all issues with logging listed in #6581

Now:

  1. GUI and Core load logger configuration from the same config file tribler_common/logger.yaml.
  2. Logger file structure was simplified, unused code was removed.
  3. Logger messages with the WARNING level are not dropping silently.
  4. Core errors that GUI reads from Core stderr go to GUI stderr.

@kozlovsky
Copy link
Collaborator Author

retest this please

@ichorid
Copy link
Contributor

ichorid commented Nov 24, 2021

retest this please

@kozlovsky kozlovsky force-pushed the fix/log_config branch 3 times, most recently from fa7443b to e30470d Compare November 24, 2021 19:57
@kozlovsky kozlovsky force-pushed the fix/log_config branch 2 times, most recently from 297a335 to b1065a6 Compare November 25, 2021 14:30
@kozlovsky
Copy link
Collaborator Author

retest this please

@kozlovsky kozlovsky force-pushed the fix/log_config branch 3 times, most recently from d415ba8 to 1e7e180 Compare November 25, 2021 17:58
@kozlovsky kozlovsky marked this pull request as ready for review November 25, 2021 18:37
@kozlovsky kozlovsky requested a review from a team as a code owner November 25, 2021 18:37
@kozlovsky kozlovsky requested review from drew2a and removed request for a team November 25, 2021 18:37
@kozlovsky kozlovsky assigned ichorid and unassigned ichorid Nov 25, 2021
drew2a
drew2a previously approved these changes Nov 25, 2021
View reviewed changes
src/tribler-common/tribler_common/logger.yaml Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/tests/test_logger.py Show resolved Hide resolved
src/tribler-gui/tribler_gui/core_manager.py Outdated Show resolved Hide resolved
ichorid
ichorid previously approved these changes Nov 25, 2021
View reviewed changes
@kozlovsky kozlovsky dismissed stale reviews from ichorid and drew2a via 6702441 November 26, 2021 13:35
drew2a
drew2a previously approved these changes Nov 26, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kozlovsky
Copy link
Collaborator Author

retest this please

@kozlovsky kozlovsky merged commit 6b885ec into Tribler:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid approved these changes

@drew2a drew2a drew2a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kozlovsky @ichorid @drew2a