Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified tag colors #6479

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Modified tag colors #6479

merged 1 commit into from
Oct 22, 2021

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Oct 21, 2021 •
edited
Loading

(credits to @drew2a for picking these colors)

The main view:

image

The edit tags dialog:

image

Based on

image

image

https://coolors.co/ecbe42

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50 devos50 changed the title Customized tag colors Modified tag colors Oct 21, 2021
@devos50 devos50 marked this pull request as ready for review October 21, 2021 13:44
@devos50 devos50 requested a review from a team as a code owner October 21, 2021 13:44
@devos50 devos50 requested review from ichorid and drew2a and removed request for a team October 21, 2021 13:44
ichorid
ichorid suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result is, tags popping out, catching the eye more than the items. This is unacceptable, the idea was to make tags less visible, not just distinguishable.

@ichorid
Copy link
Contributor

ichorid commented Oct 21, 2021

Maybe switch the colors around? Make items yellow, tags light gray?

@drew2a
Copy link
Collaborator

drew2a commented Oct 22, 2021

@ichorid thank you for your feedback.

The result is, tags popping out, catching the eye more than the items.

I guess it is not because of the color scheme, but because of random chars that use for titles in GUI mode. You don't want to focus your attention on something that looks like noise and focus it on tags as something that makes more sense.

the idea was to make tags less visible, not just distinguishable.

I disagree with this. Tags are a part of the UI, so they should be an organic part, not "just distinguishable".

Maybe switch the colors around? Make items yellow, tags light gray?

You can try to play with this and place the result here, in PR as a screenshot.
As for now, the majority of developers agreed with the current version.

@drew2a
Copy link
Collaborator

drew2a commented Oct 22, 2021

Examples of tags UI:

Stack Overflow:

image

GitHub

image

YourTrack

image

YouTube

image

TikTok

image

@devos50
Copy link
Contributor Author

devos50 commented Oct 22, 2021

Given that there is a majority agreement, I will merge this PR. Feel free to suggest alternative color schemes 👍

@devos50 devos50 merged commit 4185dca into Tribler:main Oct 22, 2021
@devos50 devos50 deleted the tag_colors branch October 22, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid requested changes

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devos50 @ichorid @drew2a