Improve upgrade speed by creating indexes at separate stage #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #50bae8 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
kozlovsky
force-pushed
the
feature/improve-upgrade-speed
branch
2 times, most recently
from
5845f9f
to
e3f197e
Compare
kozlovsky
force-pushed
the
feature/improve-upgrade-speed
branch
from
e3f197e
to
50bae8a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ichorid
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I delay the creation of usual indexes and FTS index until all data are loaded to the database. This lead to about 4x speed improvement of the upgrade process.