Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trust graph #5759

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Fix trust graph #5759

merged 2 commits into from
Dec 1, 2020

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Nov 30, 2020 •
edited
Loading

Fixes #5675

This PR updates the Trust graph previously based on Trustchain blocks to use new bandwidth accounting transaction blocks.

Major changes

  • The graph only compose two layers, layer 1 (friends), layer 2 (friend of friends)
  • GUI and REST API removes the depth parameter
  • Auto refreshing on the GUI is removed
  • Test fixes

trust-graph-new

@xoriole
Copy link
Contributor Author

xoriole commented Nov 30, 2020

retest this please

@xoriole
Copy link
Contributor Author

xoriole commented Dec 1, 2020

retest this please

@xoriole xoriole force-pushed the fix-trust-graph branch 2 times, most recently from 4716167 to 3db8ec6 Compare December 1, 2020 12:35
@xoriole xoriole marked this pull request as ready for review December 1, 2020 12:40
drew2a
drew2a previously approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you check how it works on large data.

src/tribler-core/tribler_core/modules/bandwidth_accounting/database.py Outdated Show resolved Hide resolved
src/tribler-core/tribler_core/modules/trust_calculation/trust_graph.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@xoriole
Copy link
Contributor Author

xoriole commented Dec 1, 2020

The three security hotspots reported by sonarcloud are not security issues in context of this PR.

  • sha3_224() I consider sha3 safe to use. I'm not sure why sonarcloud is complaining.
  • random.randint(1, 100) this is used in test and not a security threat

@xoriole xoriole merged commit 7ce99c4 into Tribler:devel Dec 1, 2020
@xoriole xoriole deleted the fix-trust-graph branch August 4, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink approved these changes

@drew2a drew2a drew2a left review comments

@devos50 devos50 Awaiting requested review from devos50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devel] Fix the trust graph to use our new bandwidth accounting mechanism
3 participants
@xoriole @qstokkink @drew2a