READY: Cherry-picked release-7.5 SyncChannels target_peers fix #5738
Conversation
qstokkink
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -104,7 +104,7 @@ class PopularityCommunityLauncher(IPv8CommunityLauncher): | |||
| @overlay('tribler_core.modules.metadata_store.community.gigachannel_community', 'GigaChannelCommunity') | |||
| @kwargs(metadata_store='session.mds', notifier='session.notifier') | |||
| @walk_strategy('ipv8.peerdiscovery.discovery', 'RandomWalk') | |||
| @walk_strategy('tribler_core.modules.metadata_store.community.sync_strategy', 'SyncChannels') | |||
| @walk_strategy('tribler_core.modules.metadata_store.community.sync_strategy', 'SyncChannels', target_peers=-1) | |||
There was a problem hiding this comment.
It would be nice to have a corresponding const for -1 to clarify what exactly is meant by -1
There was a problem hiding this comment.
I have two variations for you:
a) A -1 constant:
NEVER_ENOUGH = -1
...
@walk_strategy('tribler_core.modules.metadata_store.community.sync_strategy', 'SyncChannels',
target_peers=NEVER_ENOUGH)b) A dict mapping:
NEVER_STOP = {'target_peers': -1}
...
@walk_strategy('tribler_core.modules.metadata_store.community.sync_strategy', 'SyncChannels',
**NEVER_STOP)I am also open to other naming of the variable - please let me know what you prefer. At any rate, I'm not the right person to pick the variable name: I'm way too accustomed to -1 and the inner workings of IPv8.
There was a problem hiding this comment.
Thank you, @qstokkink! Both variants look very attractive.
I'm personally like the first one more than the second one.
About the name, maybe something from:
INFINITE = -1
ENDLESS = -1 There was a problem hiding this comment.
INFINITE = -1 would be the most natural option then to me.
There was a problem hiding this comment.
One moment, I'll make a PR.
This was part of the fixes on
release-7.5, but apparently it did not make its way intodevel:tribler/src/tribler-core/tribler_core/session.py
Line 248 in 1c4335c