Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY: Updated IPv8 pointer #5707

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Oct 30, 2020

Fixes #5683
NOTE: anything outside of TestBase will still hide these types of exceptions. This, for example, will still have a hidden error:

def test_a_thing():
    import asyncio
    def this_is_bad():
        raise Exception()
    asyncio.get_event_loop().call_soon(this_is_bad)

This will not:

class MyBeautifulTestCase(TestBase):
    def test_a_thing(self):
        import asyncio
        def this_is_bad():
            raise Exception()
        asyncio.get_event_loop().call_soon(this_is_bad)

This PR uncovers and fixes two tests that were secretly failing:

FAILED src/tribler-core/tribler_core/modules/metadata_store/community/tests/test_gigachannel_community.py::TestGigaChannelUnits::test_gigachannel_search
FAILED src/tribler-core/tribler_core/modules/metadata_store/community/tests/test_remote_query_community.py::TestRemoteQueryCommunity::test_remote_select_subscribed_channels

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@qstokkink qstokkink marked this pull request as ready for review October 30, 2020 12:39
@qstokkink qstokkink changed the title Updated IPv8 pointer READY: Updated IPv8 pointer Oct 30, 2020
@ichorid ichorid merged commit 9802174 into Tribler:devel Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] If exception raised while delivery, it hides from pytests
2 participants