READY: Total dirs renaming

[ichorid]

!!! ACHTUNG !!!!

Git does not preserve history through file renames. This is a known Git shortcoming. Locally, git blame should still work, but GitHub will forever show yours truly as the sole author of the moved files.

Ok, this is bad. However, considering the amount of refactoring Tribler codebase underwent through the last year, and in the wake of Blackifiyng the whole repository, this is not that bad. Otherwise, we're stuck with 😵 🍄 dRuG-aDdiCt-StyLe 🍄 😵 non-pep8 naming forever.

[ghost]

DeepCode's analysis on #e89149 found:

• ❌ 1 critical issue. ⚠️ 4 warnings and 42 minor issues. ✔️ 3 issues were fixed.
• We show critical issues and security vulnerabilities below 👇.

List of critical issues

Description of the issue ❌	Example fixes
Missing call of decode for base64.b64encode. May cause unicode problems. Occurrences: src/tribler-gui/tribler_gui/code_executor.py:59 src/tribler-gui/tribler_gui/code_executor.py:61 src/tribler-gui/tribler_gui/code_executor.py:69	Example fixes 🔧

---

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

---

☺️ If you want to provide feedback on our bot, here is how to contact us.

[qstokkink]

Could you give us a quick overview of the performed renaming in the OP*? The LOC change is rather.. daunting.

* And any changes that were non-trivial.

[ichorid]

Could you give us a quick overview of the performed renaming in the OP*? The LOC change is rather.. daunting.

• And any changes that were non-trivial.

Well, the best way to look at the new structure is to browse it: https://github.com/ichorid/tribler/tree/rename_dir
The principal idea of this PR is described in #4953. At this moment, this is still just git mv renames. The next step is to fix the imports with sed magic and make sure everything works. The last step will be the hardest one, as I'll have to adjust the infrastructure (Jenkins builds, etc).

[egbertbouman]

I have to say, compared to previous versions of your branch, I looks a lot better now that you've cleaned up the root a bit and moved to tests into separate directories.

However, considering the amount of refactoring Tribler codebase underwent through the last year, and in the wake of Blackifiyng the whole repository, this is not that bad.

Just a quick comment on code reformatting, before you make another massive pr. As far as I know blackifying the entire codebase is still up for discussion and we merely agreed it was ok to blackify gui and metadata code.

[ichorid]

Just a quick comment on code reformatting, before you make another massive pr. As far as I know blackifying the entire codebase is still up for discussion and we merely agreed it was ok to blackify gui and metadata code.

Don't worry, I'm not going to do it without every developer's consent 😉

[ichorid]

@xoriole, I consider this good and ready for merging.

[ichorid]

run_tribler.py works from PyCharm if individual src/ subdirs are marked as source dirs. This way it is compatible with potential pip packaging. Core tests pass, though Jenkins test runners still have to be adjusted.

[xoriole]

The main execution file run_tribler.py and the core tests, all seems to work fine. I think we can merge this, and fix the test runners and other issues one by one.
Also with this change, documentation and update to (now outdated) ReadMe become quite important.

[synctext]

😮 LoC: "+70,962 -71,584"

[ichorid]

open_mouth LoC: "+70,962 -71,584"

Yep, I'm holding the record for the biggest PR now 😛

[egbertbouman]

Yes, truly amazing.