READY: UTF-8 config #4043
Closed
READY: UTF-8 config #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoriole
force-pushed
the
utf-8-config
branch
from
280b241
to
6febc90
Compare
qstokkink
requested changes
Nov 19, 2018
| @@ -288,7 +288,7 @@ def on_finished(self, reply, capture_errors): | |||
|
|
|||
| data = reply.readAll() | |||
| try: | |||
| json_result = json.loads(str(data), encoding='latin_1') | |||
| json_result = json.loads(str(data), encoding='utf-8') | |||
There was a problem hiding this comment.
We also send non-utf-8 encoded strings over the request manager.
There was a problem hiding this comment.
Request manager still uses latin_1 now and the config is converted to use UTF-8.
xoriole
force-pushed
the
utf-8-config
branch
from
6febc90
to
13e7678
Compare
|
@xoriole is this one ready for merge/review? |
|
This still needs to be tested on non-utf8 systems. It seems this approach will simply fix it for the utf-8 users and break it for the rest. This will lead to a never ending whack-a-mole approach with encodings. We should use the system encoding instead. |
|
retest this please |
|
retest this please |
1 similar comment
|
retest this please |
|
As I do not believe this PR will solve our problems long term and it has gone stale, I will close this PR. It should be naturally fixed when we move to Python 3 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.