Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended TradeChain in the market community #3068

Merged
merged 5 commits into from
Sep 7, 2017
Merged

Extended TradeChain in the market community #3068

merged 5 commits into from
Sep 7, 2017

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Aug 29, 2017 •
edited
Loading

This PR contains a major refactoring of the market community. Most important features:

  • merged TradeChainCommunity and the MarketCommunity: every action in the market is now recorded on TradeChain.
  • added a message to TrustChainCommunity that allows for sending a pair of half blocks to a specific candidate
  • added functionality to TrustChainCommunity that allows for message broadcasting (using NHopCommunityDestination)
  • fixed some minor bugs and removed unused code

TradeChain:

tradechain

@devos50 devos50 force-pushed the tradechain_integration branch 2 times, most recently from d30c942 to 588771e Compare September 4, 2017 15:23
@devos50 devos50 force-pushed the tradechain_integration branch 3 times, most recently from 24c635a to fa49eaa Compare September 5, 2017 10:16
@devos50 devos50 changed the title WIP: Extended TradeChain in the market community READY: Extended TradeChain in the market community Sep 5, 2017
@devos50
Copy link
Contributor Author

devos50 commented Sep 5, 2017

@qstokkink ready for review!

qstokkink
qstokkink requested changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W0223: (abstract-method), OrderStatusRequestCache: Method 'on_timeout' is abstract in class 'NumberCache' but is not overridden this needs to be fixed.

@devos50
Copy link
Contributor Author

devos50 commented Sep 6, 2017

retest this please

2 similar comments
@devos50
Copy link
Contributor Author

devos50 commented Sep 6, 2017

retest this please

@qstokkink
Copy link
Contributor

retest this please

qstokkink
qstokkink requested changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this please W0611: (unused-import), : Unused Order imported from Tribler.community.market.core.order

@qstokkink
Copy link
Contributor

Everything else looks good.

@devos50
Copy link
Contributor Author

devos50 commented Sep 7, 2017

Created issue #3081

@devos50
Copy link
Contributor Author

devos50 commented Sep 7, 2017

retest this please

@devos50 devos50 changed the title READY: Extended TradeChain in the market community Extended TradeChain in the market community Sep 7, 2017
@devos50 devos50 merged commit f493e55 into Tribler:devel Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devos50 @qstokkink