Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented endpoint to remove and edit a playlist in a channel #2447

Merged
merged 4 commits into from
Jul 12, 2016
Merged

Implemented endpoint to remove and edit a playlist in a channel #2447

merged 4 commits into from
Jul 12, 2016

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Jul 8, 2016

No description provided.

@devos50
Copy link
Contributor Author

devos50 commented Jul 8, 2016 

stderr: fatal: The remote end hung up unexpectedly
error: RPC failed; result=18, HTTP code = 200

Github issue?

@devos50
Copy link
Contributor Author

devos50 commented Jul 8, 2016

retest this please

@devos50
Copy link
Contributor Author

devos50 commented Jul 8, 2016

@lfdversluis can you review?

@lfdversluis
Copy link

looks ok

@devos50 devos50 changed the title WIP: Implemented endpoint to remove and edit a playlist in a channel READY: Implemented endpoint to remove and edit a playlist in a channel Jul 8, 2016
@devos50
Copy link
Contributor Author

devos50 commented Jul 8, 2016

@whirm can you review?

whirm
whirm reviewed Jul 8, 2016
View reviewed changes
Tribler/Core/Modules/restapi/channels/channels_playlists_endpoint.py
message="the community for the specific channel cannot be found")

# Remove all torrents from this playlist
sql = "SELECT dispersy_id FROM PlaylistTorrents WHERE playlist_id = ?"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the DB stuff should be here.

@devos50
Copy link
Contributor Author

devos50 commented Jul 10, 2016

@whirm fixed, see my last mixup commit.

@whirm
Copy link

whirm commented Jul 11, 2016

Looks fine, squash it

@devos50 devos50 force-pushed the edit_remove_playlist_endpoint branch from b01477d to cb2c2aa Compare July 11, 2016 12:30
@devos50
Copy link
Contributor Author

devos50 commented Jul 11, 2016 

Traceback (most recent call last):
  File "C:\Python27\lib\threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Utilities\twisted_thread.py", line 55, in _reactor_runner
    reactor.run(installSignalHandlers=False)
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 1194, in run
    self.mainLoop()
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 1203, in mainLoop
    self.runUntilCurrent()
--- <exception caught here> ---
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 825, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Libtorrent\__init__.py", line 27, in <lambda>
    lambda_f = lambda a = args, kwa = kwargs: invoke_func(*a, **kwa)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Libtorrent\__init__.py", line 28, in invoke_func
    download.session.lm.threadpool.add_task(lambda_f, 1)
exceptions.AttributeError: 'NoneType' object has no attribute 'add_task'

@devos50
Copy link
Contributor Author

devos50 commented Jul 11, 2016

retest this please

@devos50
Copy link
Contributor Author

devos50 commented Jul 11, 2016

@whirm ready for merge

@whirm whirm changed the title READY: Implemented endpoint to remove and edit a playlist in a channel Implemented endpoint to remove and edit a playlist in a channel Jul 12, 2016
@whirm whirm merged commit 5639339 into Tribler:devel Jul 12, 2016
@devos50 devos50 deleted the edit_remove_playlist_endpoint branch July 12, 2016 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devos50 @lfdversluis @whirm