GuiDBTuples credit mining removal #2398
Conversation
ardhipoetra
changed the title
|
Mind to review, @devos50, @lfdversluis? |
ardhipoetra
force-pushed
the
guituples_cm_removal
branch
from
1b78780
to
a30122d
Compare
| self.loaded_torrent[infohash] = tdef | ||
|
|
||
| if callback is not None: | ||
| callback(tdef) |
There was a problem hiding this comment.
you may want to use a deferred here
|
@lfdversluis pushed commits on your feedback. What do you think? |
ardhipoetra
force-pushed
the
guituples_cm_removal
branch
from
6694c02
to
5f5db94
Compare
|
retest this please |
|
retest this please |
|
retest this please error in mac, TestDownloadsEndpoint.test_get_downloads |
| self.torrents[infohash]['num_seeders'] = torrent.swarminfo[0] or 0 | ||
| self.torrents[infohash]['num_leechers'] = torrent.swarminfo[1] or 0 | ||
| self.torrents[infohash]['name'] = torrent.get_name() | ||
| self.torrents[infohash]['metainfo'] = torrent |
There was a problem hiding this comment.
Does the torrent object really represent the metainfo of the torrent?
There was a problem hiding this comment.
I think yes, torrent object is a TorrentDef type
|
@ardhipoetra I gave my comments. Overall, it looks good and I'm glad you are able to remove much code in this PR :) |
|
@devos50 processed! :D |
|
retest this please credit mining error in Mac |
|
retest this please |
|
@ardhipoetra looks fine, let's put it on ready so @whirm can take a look. |
ardhipoetra
changed the title
|
@devos50 Thanks! :D |
|
This check_and_register() function looks a bit fishy... why do you need this? Also the |
There was a problem hiding this comment.
@ardhipoetra looks good 👍 . Besides my looping call comment, I have one additional question: can you squash the first commit (where you remove the dependency on GUIDBTuple) and the commit(s) where you refactor the _load_torrent method to use deferreds?
After that, please squash and I will merge if it's ok.
| """ | ||
| check if a torrent has been loaded | ||
| """ | ||
| if defer_param is None: |
There was a problem hiding this comment.
Please use the looping call mechanism here that I recently adopted in your tests (see the other tests in this file to see how I did that).
Closes Tribler#2356 Squashed : - Refactor to use deferred
ardhipoetra
force-pushed
the
guituples_cm_removal
branch
7 times, most recently
from
1e2d71c
to
2094ebd
Compare
|
retest this please looks good |
|
retest this please last run okay |
|
retest this please last run : error in linux, get_settings Rest Api |
|
retest this please |
|
looks stable enough for me. What do you think @devos50? |
|
retest this please |
5 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
| def add_to_loaded(infohash_str): | ||
| """ | ||
| function to add loaded infohash to memory | ||
| """ | ||
| self.loaded_torrent[unhexlify(infohash_str)].callback( | ||
| TorrentDef.load_from_memory(self.session.get_collected_torrent(unhexlify(infohash_str)))) | ||
| self.loaded_torrent[unhexlify(infohash_str)] = None | ||
|
|
||
| # self.loaded_torrent[unhexlify(infohash_str)] = None |
There was a problem hiding this comment.
Please remove this commented-out code.
Squashed commits with : - Use looping call in checking loaded torrent
ardhipoetra
force-pushed
the
guituples_cm_removal
branch
from
2094ebd
to
5b6a6f0
Compare
|
@devos50 ready! |
devos50
changed the title
As fix for Issue #2356.
This will remove
Mainpackage dependencies on credit mining. It might be slow when downloading the credit source, but it works. How can I download the torrent via DHT/Peers?Btw, made PR into
nextbecause this is a bugfix for experimental feature (credit mining)