Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill custom threadpools #1461

Merged
merged 27 commits into from
Jun 16, 2015
Merged

Kill custom threadpools #1461

merged 27 commits into from
Jun 16, 2015

Conversation

whirm
Copy link
Contributor

@whirm whirm commented Jun 8, 2015

No description provided.

@whirm whirm mentioned this pull request Jun 8, 2015
Closed
@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/46/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/48/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4337/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4339/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/53/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/54/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4344/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4345/
Test FAILed.

@NielsZeilemaker
Copy link
Contributor

I'm guessing this is not ok

GUIDBProducer: DEBUG: GUIDBHandler: Task(tribler_main.py:574 (set_reputation)) took to be called 0.0 (expected 5.0), actual task took 0.0 guiTaskQueue

expected 5s, called in 0s.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/64/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4355/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/65/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/66/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/69/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4356/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4357/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/71/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4360/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4362/
Test PASSed.

@whirm whirm force-pushed the kill_custom_threadpools branch 2 times, most recently from 65ab79b to f2740e1 Compare June 10, 2015 10:42
@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/75/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/76/
Test PASSed.

NielsZeilemaker
NielsZeilemaker reviewed Jun 10, 2015
View reviewed changes
Tribler/Core/Libtorrent/LibtorrentDownloadImpl.py
# runs on the reactor
def session_getstate_usercallback_target():
(when, getpeerlist) = usercallback(ds)
with self.dllock:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one doesn't make a lot of sense anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean acquiring the lock?

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4366/
Test PASSed.

Elric Milon added 17 commits June 16, 2015 11:59
Untangle LaunchManyCore
0e9c2ef 
By not using TwistedRawServer.perform_getstate_usercallback()
Simplifies code and allows us to remove that weird one as it's only used
in two places in Tribler.
Drop perform_getstate_usercallback()
190492f
Unused variable
d633165
Remove perform_usercallback
ad7796f 
In favor of a generic method in twisted_thread.
Remove TwistedRawServer.queueTask().
8a2a7ac 
In favor of using the generic callInThreadPool().
Implement isInThreadPool() utility function.
66b4b53
Streamline GUIDBHandler.Add() thread selection logic.
eafb723 
And don't create task ID's as TwistedRawServer will create them for us.
Fix logging entry
f645c36
Fix pydeadobject
1f3505c
Use with.
b6a291f
Document the reason of existence of warnIfDispersyThread.
78760fe
pydeadobject
71771b0
TwistedRawServer.add_task: default delay to 0.
48c6d61 
So it has the same signature than add_tast_in_thread
Synchronously call if we already are in the threadpool.
52196c0 
Save some scheduling latency.
A couple of utility functions to avoid a few lambdas.
5b75fc8
Use the rawserver instead of callInThreadPool.
28cbac8 
So we can implement a blocking stop() method later that waits for all
the tasks to be done.
pep8
9e18a49
@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/180/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/181/
Test FAILed.

@whirm
Copy link
Contributor Author

whirm commented Jun 16, 2015

The job's timeout threshold got set too low due to @rjruigrok improvements on the tunnel tests.

@whirm
Copy link
Contributor Author

whirm commented Jun 16, 2015

retest this please

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4472/
Test FAILed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4473/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester-turbo_devel/182/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/4474/
Test PASSed.

@whirm
Copy link
Contributor Author

whirm commented Jun 16, 2015

@LipuFei @NielsZeilemaker ready

LipuFei added a commit that referenced this pull request Jun 16, 2015
@LipuFei
Merge pull request #1461 from whirm/kill_custom_threadpools
011b1b7 
Kill custom threadpools
@LipuFei LipuFei merged commit 011b1b7 into Tribler:devel Jun 16, 2015
@whirm whirm deleted the kill_custom_threadpools branch June 16, 2015 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@whirm @tribler-ci @NielsZeilemaker @synctext @LipuFei