Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch unhandled exceptions and fail the tests if any has been raised #1241

Merged
merged 5 commits into from
Feb 26, 2015
Merged

Catch unhandled exceptions and fail the tests if any has been raised #1241

merged 5 commits into from
Feb 26, 2015

Conversation

whirm
Copy link
Contributor

@whirm whirm commented Feb 19, 2015

No description provided.

@tribler-ci
Copy link
Contributor

Build triggered.

@tribler-ci
Copy link
Contributor

Build started.

@tribler-ci
Copy link
Contributor

Build triggered.

@tribler-ci
Copy link
Contributor

Build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3454/

@tribler-ci
Copy link
Contributor

Build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/107/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3455/

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester-isolated_devel/108/

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Merged build finished.

@tribler-ci
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3456/

@tribler-ci
Copy link
Contributor

Merged build triggered.

@tribler-ci
Copy link
Contributor

Merged build started.

@tribler-ci
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http:https://jenkins.tribler.org/job/GH_Tribler_pull-request-tester_devel/3545/

@whirm
Copy link
Contributor Author

whirm commented Feb 25, 2015

@LipuFei I guess it's ready. The mangled log on the unit test report is still crappy but I'm trying to fix that.

@whirm
Copy link
Contributor Author

whirm commented Feb 25, 2015

@LipuFei look at the last failed run to see how it looks now in case you have any suggestion

@whirm
Copy link
Contributor Author

whirm commented Feb 25, 2015

retest this please

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3548/
Test FAILed.

@LipuFei
Copy link
Collaborator

LipuFei commented Feb 25, 2015

retest this please

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3551/
Test FAILed.

@LipuFei
Copy link
Collaborator

LipuFei commented Feb 25, 2015

retest this please

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3553/
Test PASSed.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3554/
Test PASSed.

@LipuFei
Copy link
Collaborator

LipuFei commented Feb 25, 2015

@whirm looks good. ready?

@whirm
Copy link
Contributor Author

whirm commented Feb 26, 2015

@LipuFei yup.
I'll try to fix the double logging on the report now.

@LipuFei
Copy link
Collaborator

LipuFei commented Feb 26, 2015

@whirm needs a rebase

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3559/
Test PASSed.

@LipuFei
Copy link
Collaborator

LipuFei commented Feb 26, 2015

@whirm ready?

@whirm
Copy link
Contributor Author

whirm commented Feb 26, 2015

@LipuFei yes

@whirm
Copy link
Contributor Author

whirm commented Feb 26, 2015

retest this please

@whirm
Copy link
Contributor Author

whirm commented Feb 26, 2015

@LipuFei this retest is to check something unrelated to the PR, you can merge it.

@tribler-ci
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.tribler.org//job/GH_Tribler_pull-request-tester_devel/3560/
Test PASSed.

LipuFei added a commit that referenced this pull request Feb 26, 2015
@LipuFei
Merge pull request #1241 from whirm/handle_wx_exceptions
3b1bdea 
Catch unhandled exceptions and fail the tests if any has been raised
@LipuFei LipuFei merged commit 3b1bdea into Tribler:devel Feb 26, 2015
@whirm whirm deleted the handle_wx_exceptions branch February 26, 2015 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
V6.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whirm @tribler-ci @LipuFei