Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devel] Fix the trust graph to use our new bandwidth accounting mechanism #5675

Closed
devos50 opened this issue Oct 24, 2020 · 3 comments · Fixed by #5759
Closed

[devel] Fix the trust graph to use our new bandwidth accounting mechanism #5675

devos50 opened this issue Oct 24, 2020 · 3 comments · Fixed by #5759
Assignees
@xoriole
Labels
type: bug
Milestone
Next-next release

Comments

@devos50
Copy link
Contributor

devos50 commented Oct 24, 2020

In #5623, we described and implemented a new mechanism for bandwidth accounting. Now that #5626 has been merged, the trust graph needs to be improved to use the information generated by our new bandwidth accounting mechanism. @xoriole already indicated that he would like to fix t his.

I think this is the only location in the code where TrustChain is still used. So, after this has been addressed, we can finally move TrustChain to AnyDex.
@xoriole
Copy link
Contributor

xoriole commented Nov 3, 2020

The new trust graph
trust-graph-new

@Houkime
Copy link

Houkime commented Nov 8, 2020 •
edited
Loading

devel at 8f8272d
When opening trust graph:

 File "/home/user/tribler/src/tribler-core/tribler_core/restapi/rest_manager.py", line 43, in error_middleware
    response = await handler(request)
  File "/usr/lib/python3.8/site-packages/aiohttp/web_middlewares.py", line 119, in impl
    return await handler(request)
  File "/home/user/tribler/src/tribler-core/tribler_core/restapi/trustview_endpoint.py", line 209, in get_view
    self.initialize_graph()
  File "/home/user/tribler/src/tribler-core/tribler_core/restapi/trustview_endpoint.py", line 161, in initialize_graph
    if self.session.trustchain_community:
AttributeError: 'Session' object has no attribute 'trustchain_community'

It seems like trustchain thing is already absent from session, but trust graph still uses it.

@devos50
Copy link
Contributor Author

devos50 commented Nov 8, 2020

Thanks for pointing this out! @xoriole is currently working on it and we aim to address this issue very soon (likely somewhere next week) 👍

@xoriole xoriole mentioned this issue Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoriole xoriole

Labels
type: bug
Projects
None yet
Milestone
Next-next release
Development

Successfully merging a pull request may close this issue.

Fix trust graph xoriole/tribler
4 participants
@xoriole @devos50 @drew2a @Houkime