Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libswift downloads don't have a proper filename #33

Closed
synctext opened this issue Mar 15, 2013 · 5 comments
Closed

Libswift downloads don't have a proper filename #33

synctext opened this issue Mar 15, 2013 · 5 comments
Assignees

Comments

@synctext
Copy link
Member

Now it's just the roothash.
for 30 seconds

@NielsZeilemaker
Copy link
Contributor

Initially a SwiftDownload will only have a roothash, no name is available.
Maybe we could extend the swift-url spec to include a displayname (dn) similar to magnet links.
Then we can use the dn to set the name.

@arno481
Copy link

arno481 commented Mar 22, 2013

On 22/03/2013 11:58, NielsZeilemaker wrote:

Initially a SwiftDownload will only have a roothash, no name is available.
Maybe we could extend the swift-url spec to include a displayname (dn)
similar to magnet links.
Then we can use the dn to set the name.

Practically, if you know the filename from e.g. the .torrent you can set
the dest dir to that filename and the swift engine will safe it under
that name.

More generally, you could also make the filename part of the content,
e.g. by creating a multi-file swarm that contains just one file. The
name is then protected from modification by the root hash, unlike in the
dn case.

Just something to think about,
Arno

@NielsZeilemaker
Copy link
Contributor

It should only happen if we don't have a .torrent, as if we do then the MyPreferences database row will point to a torrent and then simply use the swarmname of the torrent.

If it happens when we have the .torrent, then this is caused by a bug. Personally, it never happend to me and without a clear example it would be hard to replicate.

@ghost ghost assigned egbertbouman Apr 25, 2013
NielsZeilemaker added a commit that referenced this issue May 13, 2013
GuiDBHandler reconnects to current databasethread during unittests
@whirm
Copy link
Contributor

whirm commented Jul 8, 2014

@egbertbouman I think we can safely close that one?

@egbertbouman
Copy link
Member

@whirm I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants