Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bootstrap with infinite max_peers #1286

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fixed bootstrap with infinite max_peers #1286

merged 2 commits into from
Mar 7, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Mar 6, 2024 •
edited
Loading

Fixes #1277
Fixes #1289

This PR:

  • Fixes Community._bootstrap() to allow infinite (-1) max_peers.
  • Fixes tests locking up on some machines due to LAN address resolution.

@qstokkink qstokkink closed this Mar 6, 2024
@qstokkink qstokkink reopened this Mar 6, 2024
@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Fixed bootstrap with infinite max_peers READY: Fixed bootstrap with infinite max_peers Mar 7, 2024
@qstokkink qstokkink marked this pull request as ready for review March 7, 2024 12:45
@qstokkink qstokkink changed the title READY: Fixed bootstrap with infinite max_peers Fixed bootstrap with infinite max_peers Mar 7, 2024
@qstokkink qstokkink merged commit cd5991e into Tribler:master Mar 7, 2024
6 checks passed
@qstokkink qstokkink deleted the fix_inf_bootstrap branch March 7, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The test suite locks up on (some) Mac(s) Community _bootstrap cannot deal with infinite max peers
2 participants
@qstokkink @egbertbouman