feat: allow custom loading manager to useTexture #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiexd TextureLoader use THREE.DefaultLoadingManager as default loading manager form: Tresjs#432
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hawk86104
changed the title
hawk86104
changed the title
hawk86104
changed the title
alvarosabu
approved these changes
Mar 12, 2024
alvarosabu
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks @hawk86104 for this PR, could you also update the documentation under docs/ to reflect these changes?
These changes should be a feat instead of a chore or fix since they add a new option to the end user.
alvarosabu
changed the title
alvarosabu
changed the title
remove the comment Co-authored-by: Alvaro Saburido <[email protected]>
|
Nice addition. Small and flexible! |
…manager to useTexture'
|
alvarosabu
requested changes
Mar 13, 2024
alvarosabu
added
feature
p2-nice-to-have
alvarosabu
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fiexd TextureLoader use THREE.DefaultLoadingManager as default loading manager form: #432