-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixed typos and small enhancements in en docs, fixed dead links in de #567 #566
Conversation
caveats, composables, devtools, migration guide and troubleshooting pages
β Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
caveats, composables, devtools, migration guide and troubleshooting pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Lots of good changes here.
I made some comments. Most are "non-blocking" and are marked.
For those not marked "non-blocking" reply to me if you disagree. Otherwise, if you find the changes acceptable, go ahead and add them to the PR.
(I should say up front that I'm not an editor. My only "qualification" here is being an anglophone working on Tres/Cientos!)
Thanks again!
@andretchen0 I addressed all your comments since I like the approach of fixing things that only take a minute right away. π€π½ Please have a second look at it, I also rephrased the part with the "in summary". But probably one person of the core team should comment on that point anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I found one more instance of double quotes in TypeScript code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Approved.
@alvarosabu from my side this is ready to go - maybe you or @JaimeTorrealba have a quick look at the sentence in the light-shadows.md and if the meaning of it is correct after my update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, for me is ready
Great thanks for the feedback @JaimeTorrealba , then I resolve the remaining open threads. I just resolved the merge conflict so it would also be ready to merge from my side. |
π Linked issue
Closes #567
β Type of change
π Description
Fixed some typos in the documentation and adjusted the descriptions where I saw fit so the "reading flow" is a bit better :)
I checked this draft PR and it seems that my changes do not overlap with it: #495
Also there were some german links that the linter marked as dead or incorrect, I fixed those too.
Resolves #567
π Checklist
main
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Other information: