Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force memory free allocation when disposing materials and geomeries #463

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix: force memory free allocation when disposing materials and geomeries #463

merged 1 commit into from
Dec 9, 2023

Conversation

alvarosabu
Copy link
Member

Closes #449

  • Forces memory free when disposing materials and geometries
  • exposes hard dispose method

@alvarosabu alvarosabu added bug Something isn't working performance labels Dec 4, 2023
@alvarosabu alvarosabu requested a review from Tinoooo December 4, 2023 18:34
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 7d8c7a1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/656e1bcb9f0a81000898564e
😎 Deploy Preview https://deploy-preview-463--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu merged commit 1ef3533 into main Dec 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinoooo Tinoooo Tinoooo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working performance
Projects
Team Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak caused by non disposed scene, when using routes
2 participants
@alvarosabu @Tinoooo