Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly.GetTypes can throw ReflectionTypeLoadException #24

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

SergeyGulik
Copy link

Assembly.GetTypes can throw ReflectionTypeLoadException when the assembly references types from other currently missing assemblies.
In my case it led to Probe failure.
Suggested wrapping extension method handles ReflectionTypeLoadException gracefully.

…mbly references types from other currently missing assemblies.

In my case it led to Probe failure.
Suggested wrapping extension method handles ReflectionTypeLoadException gracefully.
Copy link
Contributor

@PatrickRitchie PatrickRitchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and tested successfully. I will pull these changes into the main branch and I should have a new Release and Nuget package available tonight.

Thanks!
-Patrick

@PatrickRitchie PatrickRitchie merged commit 700e7b1 into TrakHound:master Apr 26, 2022
@SergeyGulik SergeyGulik deleted the gettypes_may_fail branch April 28, 2022 07:17
@SergeyGulik
Copy link
Author

Was 3.3.1 the version with the fix? I still have the problem with it.

@PatrickRitchie
Copy link
Contributor

@SergeyGulik It looks like the v3.3.1 package was built using the correct commit.

image

Note that the Assembly file version is incorrect and I will fix that on the next version.

I will try and run a few more tests to see if I can reproduce the issue.

@SergeyGulik
Copy link
Author

Hi Patrick,
Sorry, it was my mistake somewhere. After several rebuilds it works fine.
Thank you a lot!

@PatrickRitchie
Copy link
Contributor

@SergeyGulik Ok thanks for the update.

Thanks again for all of the contributions and feedback!

  • Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants