Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amendment #2

Closed
wants to merge 2 commits into from
Closed

amendment #2

wants to merge 2 commits into from

Conversation

gleamy
Copy link

@gleamy gleamy commented Apr 26, 2017

amendment

@PatrickRitchie
Copy link
Contributor

Thanks for taking the time to submit a Pull Request! I am however a little confused as to what you are wanting to accomplish with the changes. Can you add a description?

It looks like you are wanting to add the ability to read from multiple Devices using the same MTConnectClient class. This class was intended to be used for a single device although if this is something you and/or others are wanting, we may need to change a few other things as well to get the raised events to work correctly. Typically multiple devices are read by a Probe request first, then for each Device found, a MTConnectClient is started for each.

@gleamy
Copy link
Author

gleamy commented Apr 27, 2017

Thanks for your reply

I just want to when we are not sure to collect the device,MTConnectClient can return all of the data for us.

In addition, MTConnectClient did not say it is only for a single device

@PatrickRitchie
Copy link
Contributor

Sorry for the delay. We are looking over what it will take to make this work correctly. The main issue is how to handle the AssetChanged data item which will now have to be stored for each device. Shouldn't be too difficult but does change a few things. I'll make sure to include this along with the changes you made to the Url.

@PatrickRitchie
Copy link
Contributor

This is addressed with v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants