-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Deliver UserResource in StatusResource #2565
✨ Deliver UserResource in StatusResource #2565
Conversation
Could also be interesting for you, @marhei and @bendix-dev |
Generell bin ich dabei - ich würde dann, wenn der Key Die Änderung könnte so aber die API Responses stark verlangsamen. Wir sollten an der Stelle Resourcen nutzen, die weniger viele Daten ausgeben. Bei jedem Status z.B. die totale |
Find ich gut :)
Also quasi eine "schlanke" UserResource, die das wichtigste Zeug ohne Berechnungen beinhaltet? |
Exakt! I mean, was braucht man an der Stelle? Einwände? (cc @marhei, @bendix-dev, @vainamov, @HerrLevin) |
Passt von meiner Seite her! Die Umbenennung zurück in |
Ich hätte gerne noch die URL zum Mastodon-Account (das war die Intention hinter dem PR), aber sonst wäre ich auch glücklich :) |
Passt für mich, ich brauche fürs Erste nur die Felder, die auch vorher schon da waren. |
# Conflicts: # API_CHANGELOG.md # app/Http/Resources/StatusResource.php # app/Virtual/Models/Status.php
Deprecation noticeNote Backwards compatibility guaranteed until August 2024. The
This data is also available in the {
"data": {
...
"user": 1, //deprecated - removed after 2024-08
"username": "Gertrud123", //deprecated - removed after 2024-08
"profilePicture": "https://traewelling.de/@Gertrud123/picture", //deprecated - removed after 2024-08
"preventIndex": false, //deprecated - removed after 2024-08
...
"userDetails": { //new - but deprecated. See below.
"id": 1,
"displayName": "Gertrud",
"username": "Gertrud123",
"profilePicture": "https://traewelling.de/@Gertrud123/picture",
"mastodonUrl": "https://traewelling.social/@Gertrud123",
"preventIndex": false
}
}
} Looking aheadThe new key (@Traewelling/api-consumer - to subscribe to breaking api changes see #2619) |
This PR implements, that within the
StatusResource
the wholeUserResource
will be transmitted and not just bits of it.Open questions:
userDetails
sinceuser
was already taken by the ID. Maybe you have a better name? (In future after deleting the conflicting fields, it could be renamed touser
again)