Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK 14 #36

Merged
merged 7 commits into from
Sep 6, 2020
Merged

Upgrade to JDK 14 #36

merged 7 commits into from
Sep 6, 2020

Conversation

Toparvion
Copy link
Owner

@Toparvion Toparvion commented May 10, 2020

The upgrading to JDK 14 is extracted into separate PR because of compatibility issue in SonarCloud. I hope it will be resolved soon.

To merge this PR we should:

  • ensure that SonarCloud works with builds on JDK14
  • revert the change in Travis badge (in README.md) to make it point to master branch

@Toparvion Toparvion self-assigned this May 10, 2020
@Toparvion Toparvion requested a review from a-polyudov May 10, 2020 01:52
README.md Outdated Show resolved Hide resolved
@Toparvion
Copy link
Owner Author

Toparvion commented May 14, 2020

Now SonarCloud does not break the build though it still doesn't recognize JDK 14 bytecode, see this build log:

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 58
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
	at org.sonar.java.bytecode.se.MethodLookup.lookup(MethodLookup.java:68)
	at org.sonar.java.bytecode.se.MethodLookup.lookup(MethodLookup.java:60)
	at org.sonar.java.bytecode.se.BytecodeEGWalker.execute(BytecodeEGWalker.java:316)
	at org.sonar.java.bytecode.se.BytecodeEGWalker.getMethodBehavior(BytecodeEGWalker.java:293)
	... 254 common frames omitted

This should be fixed with Sonar updating to ASM 8.0.

README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@Toparvion Toparvion merged commit 2389015 into master Sep 6, 2020
@Toparvion Toparvion deleted the jdk14 branch September 6, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants