-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadlock due to race condition in WebSocketServer.stop #373
Labels
Comments
felixvf
pushed a commit
to felixvf/Java-WebSocket
that referenced
this issue
Feb 23, 2016
pau101
added a commit
to Gegy/Slyther
that referenced
this issue
May 31, 2016
Revises the following: TooTallNate/Java-WebSocket#341 TooTallNate/Java-WebSocket#373 blackrock/Java-WebSocket@a7fb7f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In line
Java-WebSocket/src/main/java/org/java_websocket/server/WebSocketServer.java
Line 220 in e4c248a
the source code reads
but it should read
Else it may happen that the selector thread wakes up and goes to sleep again, and only afterwards the selector thread is marked as interrupted (but nothing happens), which means that the selector thread sleeps forever. Due to the
join()
, the thread callingstop()
will then also sleep forever.The text was updated successfully, but these errors were encountered: