-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force client to use the valid schema #1026
Milestone
Comments
@yindex thx for creating the issue. |
yindex
pushed a commit
to yindex/Java-WebSocket
that referenced
this issue
May 23, 2020
add unit test for schema check
yindex
pushed a commit
to yindex/Java-WebSocket
that referenced
this issue
May 23, 2020
add unit test for schema check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Yes.
When I use the invalid schema(https, http) with explicit port in uri
MayBe, I can't find the potential the problem, because it can run without exception.
But, it will failed when we omit the port in uri. and It will throw an exception:"unkown schema http"
I'm alway frustrated when run failed only with different config in prod environment.
I think we should allow user to find the potential problem during development.
Describe the solution you'd like
always check the schema and throw exception on invalid schema, regardless whether the port is explicit set(no matter uri.getPort() == -1).
The text was updated successfully, but these errors were encountered: