parameterize install.sh #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parameterize `install.sh` * Add usage, logging, example output * Allow override of DNS server, image name, friendly name, model name * Move docker-compose.yml to template.
|
@TonyTromp this is totally unrelated to this PR, but issues are off so this is the only place I could put this comment. Just wanted to say - awesome work! Glad someone had more time to commit to it than me. Was trying to get it working in balena-sound a while ago but got a bit busy |
|
Agree. Sorry for hijacking. Awesome work. Have it working containerised on Rasperian alongside Pihole, and Home Assistant on a Pi 3b. I think you should turn on issues. Even if you don't have time to respond to everything. Might do a PR to flesh out the steps for non HiFi berry folks. |
|
Hi there,
Noted. I will turn it on so there is a good logging of issues.
Thanks,
Tony
…On Sat, Oct 23, 2021 at 8:39 AM old-square-eyes ***@***.***> wrote:
Agree. Sorry for hijacking. Awesome work. Have it working containerised on
Rasperian alongside Pihole, and Home Assistant on a Pi 3b. I think you
should turn on issues. Even if you don't have time to respond to everything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ4MXYLQW4J3SB744H6M53UIJKB3ANCNFSM5GM7VMRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install.sh