feat: include bridge port 10002, used in new devices in broadcast discovery

[liadav]

Description

In newer firmware version of Switcher V2, the broadcast port changed from 20002 to 10002. I added this port to the bridge discovery code.

Related issue (if any): fixes #592

Checklist

• [V] I have followed this repository's contributing guidelines.
• [V] I will adhere to the project's code of conduct.

[welcome]

Thanks for opening this pull request! Please check out our contributing guidelines.

[TomerFi]

Thank you @liadav.
This is a "hot topic", more people should be involved.

@dmatik Do you mind being involved in this too?
Do you know if we have a way to differentiate the new type1 from the old ones, so we can perhaps set the port in code?

[dmatik]

Sure. I can help.
Not sure about any way to differentiate.
I have installed recently new Switcher Touch V3.
Did not have issue to retrieve the ID using the old script.
I am still using the WebAPI approach, not integration.

[liadav]

Based on my initial research, it looks like the only thing that's different is the broadcast port. So, I think we just need to add that for the discovery phase. It shouldn't matter whether it's a new type1 or an old one.
By the way, if you want, we can run some tests on my device to make sure everything is working properly.

[codecov]

Codecov Report

Merging #642 (ea8245e) into dev (fa40529) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #642   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          11       11           
  Lines        1092     1093    +1     
=======================================
+ Hits         1074     1075    +1     
  Misses         18       18           

[TomerFi]

Sure. I can help.
Not sure about any way to differentiate.
I have installed recently new Switcher Touch V3.
Did not have issue to retrieve the ID using the old script.
I am still using the WebAPI approach, not integration.

@dmatik Oh yeah, you're right.
I was away from this project for so long, I forgot some of the implementation specifications.
After reviewing this, I now remember that the this port is used only by the Bridge, and not the API.
So we probably, don't need to do anything for the WebAPI as it doesn't use the Bridge.
:-)

[TomerFi]

Based on my initial research, it looks like the only thing that's different is the broadcast port. So, I think we just need to add that for the discovery phase. It shouldn't matter whether it's a new type1 or an old one. By the way, if you want, we can run some tests on my device to make sure everything is working properly.

@liadav Thank you very much for you contribution.
Do you mind having a look at the discover_devices script? It also uses the same port variables.

We also need to include it in the script's help sections, which mentions the original ports only.

[liadav]

Sure, I added both to discover_devices script and the script's help section.

[TomerFi]

LGTM
Thank you @liadav .

@dmatik I think we can merge this now, WDYT?

[dmatik]

LGTM

Thank you @liadav .

@dmatik I think we can merge this now, WDYT?

Yes, sure.

[welcome]

Congrats on merging your first pull request! Your contribution is highly appriciated!

[TomerFi]

@all-contributors add @liadav for code

[allcontributors]

@TomerFi

I've put up a pull request to add @liadav! 🎉