Handle special swing #492

jafar-atili · 2022-05-31T17:38:21Z

Pull Request

First PR? don't hesitate, push it.

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

I have followed this repository's contributing guidelines.
I have used the conventional commits specification for my commit messages.
I have signed my commits.
I will adhere to the project's code of conduct.

Additional information

Anything else?

jafar-atili · 2022-05-31T17:49:02Z

Few comments about this PR:

It doesn't have to make it to the next release, it only means that the following AC remotes won't have vertical swing feature: ["ELEC7022", "ZM079055", "ZM079065", "ZM079049", "ZM079065"]
even with this PR there's a problem, the following remote types ["ELEC7022","ZM079055","ZM079065"] have the same code, hence, their swing control is toggle which means that control_device.py -s on -w on can toggle the swing back to off.
Switcher have a problem reading the UDP/TCP swing state of ACs from item 1, they will always report that the swing is STOPped even if its working, so the this another problem that can make the UI swing state be out of sync with the actual swing state.

My 2 cents,
Jafar.

scripts/control_device.py

src/aioswitcher/api/__init__.py

TomerFi · 2022-06-29T08:41:01Z

This needs rebasing.

jafar-atili · 2022-07-26T09:08:26Z

@TomerFi, your Git abilities is required here, I tried to rebase on the local repo, now it doesn't like some commit messages

TomerFi · 2022-07-26T17:55:53Z

@jafar-atili
I'm working on this - will be done soon.

Signed-off-by: Jafar Atili <[email protected]>

BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]>

Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]>

Signed-off-by: Jafar Atili <[email protected]>

…ch was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]>

Signed-off-by: Jafar Atili <[email protected]>

codecov · 2022-07-26T18:55:46Z

Codecov Report

❗ No coverage uploaded for pull request base (release/v3@5042e53). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/v3     #492   +/-   ##
=============================================
  Coverage              ?   99.14%           
=============================================
  Files                 ?       10           
  Lines                 ?     1054           
  Branches              ?        0           
=============================================
  Hits                  ?     1045           
  Misses                ?        9           
  Partials              ?        0

Signed-off-by: Tomer Figenblat <[email protected]>

* fix: fixed swing mode control on special remotes Signed-off-by: Jafar Atili <[email protected]> * fix: fixed issues to handle special swing mode Signed-off-by: Jafar Atili <[email protected]> * feat: add switcher protocol type BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]> * feat: build protocol type help dynamically Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]> * test: added breeze tests Signed-off-by: Jafar Atili <[email protected]> * test: completed tests to 98% coverage Signed-off-by: Jafar Atili <[email protected]> * test: fixed formatting Signed-off-by: Jafar Atili <[email protected]> * test: renamed txt to json Signed-off-by: Jafar Atili <[email protected]> * fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (which was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]> * feat: added option to cache IRSet files Signed-off-by: Jafar Atili <[email protected]> * style: fixed imports with isort Signed-off-by: Jafar Atili <[email protected]> * docs: added misspelled words to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * docs: added missing new line to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * fix: improved the code and fixed PR comments Signed-off-by: Jafar Atili <[email protected]> * chore: remove unused wordlist file Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

Signed-off-by: Jafar Atili <[email protected]> Signed-off-by: thecode <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

jafar-atili requested review from TomerFi and thecode as code owners May 31, 2022 17:38

pull-request-size bot added the size: m Pull request has 30 to 100 lines label May 31, 2022

trafico-bot bot added the status: needs review Pull request needs a review label May 31, 2022

auto-assign bot assigned jafar-atili May 31, 2022

thecode marked this pull request as draft May 31, 2022 19:28

TomerFi requested changes Jun 15, 2022

View reviewed changes

trafico-bot bot added status: changes requested Pull request changes requested and removed status: needs review Pull request needs a review labels Jun 15, 2022

pull-request-size bot removed the size: m Pull request has 30 to 100 lines label Jul 25, 2022

trafico-bot bot added the status: needs review Pull request needs a review label Jul 25, 2022

pull-request-size bot added the size: xxl Pull request has more then 1000 lines label Jul 25, 2022

trafico-bot bot removed the status: changes requested Pull request changes requested label Jul 25, 2022

pull-request-size bot added size: m Pull request has 30 to 100 lines and removed size: xxl Pull request has more then 1000 lines labels Jul 26, 2022

jafar-atili marked this pull request as ready for review July 26, 2022 09:42

jafar-atili and others added 10 commits July 26, 2022 21:08

fix: fixed swing mode control on special remotes

18bdfd5

Signed-off-by: Jafar Atili <[email protected]>

fix: fixed issues to handle special swing mode

32e025a

Signed-off-by: Jafar Atili <[email protected]>

feat: add switcher protocol type

c92546b

BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]>

feat: build protocol type help dynamically

11f2768

Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]>

test: added breeze tests

0eb9852

Signed-off-by: Jafar Atili <[email protected]>

test: completed tests to 98% coverage

ed9f602

Signed-off-by: Jafar Atili <[email protected]>

test: fixed formatting

966e57b

Signed-off-by: Jafar Atili <[email protected]>

test: renamed txt to json

3c72935

Signed-off-by: Jafar Atili <[email protected]>

fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (whi…

46bf536

…ch was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]>

feat: added option to cache IRSet files

4798c57

Signed-off-by: Jafar Atili <[email protected]>

jafar-atili added 4 commits July 26, 2022 21:19

style: fixed imports with isort

00e1a69

Signed-off-by: Jafar Atili <[email protected]>

docs: added misspelled words to spelling_wordlist.txt

4bafda4

Signed-off-by: Jafar Atili <[email protected]>

docs: added missing new line to spelling_wordlist.txt

b1dde27

Signed-off-by: Jafar Atili <[email protected]>

fix: improved the code and fixed PR comments

3a484a0

Signed-off-by: Jafar Atili <[email protected]>

TomerFi force-pushed the handle_special_swing branch from 178b6ef to 3a484a0 Compare July 26, 2022 18:51

pull-request-size bot added size: l Pull request has 100 to 500 lines and removed size: m Pull request has 30 to 100 lines labels Jul 26, 2022

chore: remove unused wordlist file

4975da1

Signed-off-by: Tomer Figenblat <[email protected]>

pull-request-size bot added size: m Pull request has 30 to 100 lines and removed size: l Pull request has 100 to 500 lines labels Jul 26, 2022

TomerFi approved these changes Jul 26, 2022

View reviewed changes

trafico-bot bot added status: approved Pull request is approved and removed status: needs review Pull request needs a review labels Jul 26, 2022

TomerFi merged commit d36e5ec into TomerFi:release/v3 Jul 26, 2022

trafico-bot bot added status: merged Pull request merged and removed status: approved Pull request is approved labels Jul 26, 2022

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

af6f94e

Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

229d993

Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

701fe89

Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

2906f12

Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

839bd78

Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

37f2351

Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

TomerFi added a commit that referenced this pull request Sep 13, 2022

chore: handle special swing (#492)

f0d7412

Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle special swing #492

Handle special swing #492

jafar-atili commented May 31, 2022 •

edited

Loading

jafar-atili commented May 31, 2022 •

edited

Loading

TomerFi commented Jun 29, 2022

jafar-atili commented Jul 26, 2022

TomerFi commented Jul 26, 2022

codecov bot commented Jul 26, 2022 •

edited

Loading

Handle special swing #492

Handle special swing #492

Conversation

jafar-atili commented May 31, 2022 • edited Loading

Pull Request

Description

Checklist

Additional information

jafar-atili commented May 31, 2022 • edited Loading

TomerFi commented Jun 29, 2022

jafar-atili commented Jul 26, 2022

TomerFi commented Jul 26, 2022

codecov bot commented Jul 26, 2022 • edited Loading

Codecov Report

jafar-atili commented May 31, 2022 •

edited

Loading

jafar-atili commented May 31, 2022 •

edited

Loading

codecov bot commented Jul 26, 2022 •

edited

Loading