-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle special swing #492
Handle special swing #492
Conversation
Few comments about this PR:
My 2 cents, |
This needs rebasing. |
@TomerFi, your Git abilities is required here, I tried to rebase on the local repo, now it doesn't like some commit messages |
@jafar-atili |
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]>
Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
…ch was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
Signed-off-by: Jafar Atili <[email protected]>
178b6ef
to
3a484a0
Compare
Codecov Report
@@ Coverage Diff @@
## release/v3 #492 +/- ##
=============================================
Coverage ? 99.14%
=============================================
Files ? 10
Lines ? 1054
Branches ? 0
=============================================
Hits ? 1045
Misses ? 9
Partials ? 0 |
Signed-off-by: Tomer Figenblat <[email protected]>
* fix: fixed swing mode control on special remotes Signed-off-by: Jafar Atili <[email protected]> * fix: fixed issues to handle special swing mode Signed-off-by: Jafar Atili <[email protected]> * feat: add switcher protocol type BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]> * feat: build protocol type help dynamically Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]> * test: added breeze tests Signed-off-by: Jafar Atili <[email protected]> * test: completed tests to 98% coverage Signed-off-by: Jafar Atili <[email protected]> * test: fixed formatting Signed-off-by: Jafar Atili <[email protected]> * test: renamed txt to json Signed-off-by: Jafar Atili <[email protected]> * fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (which was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]> * feat: added option to cache IRSet files Signed-off-by: Jafar Atili <[email protected]> * style: fixed imports with isort Signed-off-by: Jafar Atili <[email protected]> * docs: added misspelled words to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * docs: added missing new line to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * fix: improved the code and fixed PR comments Signed-off-by: Jafar Atili <[email protected]> * chore: remove unused wordlist file Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
* fix: fixed swing mode control on special remotes Signed-off-by: Jafar Atili <[email protected]> * fix: fixed issues to handle special swing mode Signed-off-by: Jafar Atili <[email protected]> * feat: add switcher protocol type BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]> * feat: build protocol type help dynamically Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]> * test: added breeze tests Signed-off-by: Jafar Atili <[email protected]> * test: completed tests to 98% coverage Signed-off-by: Jafar Atili <[email protected]> * test: fixed formatting Signed-off-by: Jafar Atili <[email protected]> * test: renamed txt to json Signed-off-by: Jafar Atili <[email protected]> * fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (which was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]> * feat: added option to cache IRSet files Signed-off-by: Jafar Atili <[email protected]> * style: fixed imports with isort Signed-off-by: Jafar Atili <[email protected]> * docs: added misspelled words to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * docs: added missing new line to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * fix: improved the code and fixed PR comments Signed-off-by: Jafar Atili <[email protected]> * chore: remove unused wordlist file Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
* fix: fixed swing mode control on special remotes Signed-off-by: Jafar Atili <[email protected]> * fix: fixed issues to handle special swing mode Signed-off-by: Jafar Atili <[email protected]> * feat: add switcher protocol type BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]> * feat: build protocol type help dynamically Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]> * test: added breeze tests Signed-off-by: Jafar Atili <[email protected]> * test: completed tests to 98% coverage Signed-off-by: Jafar Atili <[email protected]> * test: fixed formatting Signed-off-by: Jafar Atili <[email protected]> * test: renamed txt to json Signed-off-by: Jafar Atili <[email protected]> * fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (which was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]> * feat: added option to cache IRSet files Signed-off-by: Jafar Atili <[email protected]> * style: fixed imports with isort Signed-off-by: Jafar Atili <[email protected]> * docs: added misspelled words to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * docs: added missing new line to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * fix: improved the code and fixed PR comments Signed-off-by: Jafar Atili <[email protected]> * chore: remove unused wordlist file Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
* fix: fixed swing mode control on special remotes Signed-off-by: Jafar Atili <[email protected]> * fix: fixed issues to handle special swing mode Signed-off-by: Jafar Atili <[email protected]> * feat: add switcher protocol type BREAKING CHANGE: SwitcherBridge broadcast ports changed to list Signed-off-by: thecode <[email protected]> * feat: build protocol type help dynamically Signed-off-by: thecode <[email protected]> chore: revert black Signed-off-by: thecode <[email protected]> * test: added breeze tests Signed-off-by: Jafar Atili <[email protected]> * test: completed tests to 98% coverage Signed-off-by: Jafar Atili <[email protected]> * test: fixed formatting Signed-off-by: Jafar Atili <[email protected]> * test: renamed txt to json Signed-off-by: Jafar Atili <[email protected]> * fix: removed ELEC7022_NO_DRY.json and used ELEC7022_INVALID.json (which was also cleaned from unused data) for testing the same scenario Signed-off-by: Jafar Atili <[email protected]> * feat: added option to cache IRSet files Signed-off-by: Jafar Atili <[email protected]> * style: fixed imports with isort Signed-off-by: Jafar Atili <[email protected]> * docs: added misspelled words to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * docs: added missing new line to spelling_wordlist.txt Signed-off-by: Jafar Atili <[email protected]> * fix: improved the code and fixed PR comments Signed-off-by: Jafar Atili <[email protected]> * chore: remove unused wordlist file Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Signed-off-by: thecode <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Signed-off-by: thecode <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: Jafar Atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Signed-off-by: jafar-atili <[email protected]> Co-authored-by: thecode <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]>
Pull Request
Description
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information