fix: validate users and groups bugs (tkestack#200)

TomatoAres · Mar 23, 2020 · f8a0693 · f8a0693
1 parent ca23b17
commit f8a0693
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/pkg/auth/registry/localgroup/validation.go b/pkg/auth/registry/localgroup/validation.go
@@ -65,9 +65,10 @@ func ValidateLocalGroup(group *auth.LocalGroup, authClient authinternalclient.Au
  } else {
  group.Status.Users[i].Name = val.Spec.Username
  validUsers = append(validUsers, group.Status.Users[i])
-
  }
  }
+ } else {
+ validUsers = append(validUsers, group.Status.Users[i])
  }
  }
 

diff --git a/pkg/auth/registry/policy/validation.go b/pkg/auth/registry/policy/validation.go
@@ -92,6 +92,8 @@ func ValidatePolicy(policy *auth.Policy, authClient authinternalclient.AuthInter
  validUsers = append(validUsers, policy.Status.Users[i])
  }
  }
+ } else {
+ validUsers = append(validUsers, policy.Status.Users[i])
  }
  }
 
@@ -119,6 +121,8 @@ func ValidatePolicy(policy *auth.Policy, authClient authinternalclient.AuthInter
  validGroups = append(validGroups, policy.Status.Groups[i])
  }
  }
+ } else {
+ validGroups = append(validGroups, policy.Status.Groups[i])
  }
  }
 

diff --git a/pkg/auth/registry/role/validation.go b/pkg/auth/registry/role/validation.go
@@ -85,6 +85,8 @@ func ValidateRole(role *auth.Role, authClient authinternalclient.AuthInterface)
  validUsers = append(validUsers, role.Status.Users[i])
  }
  }
+ } else {
+ validUsers = append(validUsers, role.Status.Users[i])
  }
  }
 
@@ -112,6 +114,8 @@ func ValidateRole(role *auth.Role, authClient authinternalclient.AuthInterface)
  validGroups = append(validGroups, role.Status.Groups[i])
  }
  }
+ } else {
+ validGroups = append(validGroups, role.Status.Groups[i])
  }
  }