Improve performance of Location Display (PLD) #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm8263
reviewed
Feb 10, 2022
move many CPU-intensive tasks to delayed loop
TomGrobbe
approved these changes
Mar 4, 2023
Drift91
pushed a commit
to Drift91/vMenu
that referenced
this pull request
Aug 3, 2023
Improve performance of Location Display (PLD)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves CPU timings when turning on the PLD in Misc Settings.
I moved many of the CPU-intensive tasks (like
World.GetStreetName(currentPos)andWorld.GetZoneLocalizedName(currentPos)) to the 200ms loop instead of being called every tick. This drastically improves the performance while having the PLD on, I noticed timings going from0.9msto0.6ms(on foot and menu closed).The warning that it takes up a large part of your CPU is still on the menu button, but it can be removed if you think that the issue is fixed!