Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test a few cmake option combinations before the build. #380

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Test a few cmake option combinations before the build. #380

merged 1 commit into from
Jan 5, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 4, 2017 •
edited
Loading

This takes a few seconds but allows us to cover cases that aren't checked
often.

This change is Reviewable

@iphydf iphydf added this to the v0.1.3 milestone Jan 4, 2017
@iphydf iphydf force-pushed the test-cmake-combos branch 3 times, most recently from 2f139db to 44973b0 Compare January 4, 2017 22:41
@Diadlo
Copy link

Diadlo commented Jan 5, 2017

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

CMakeLists.txt, line 505 at r1 (raw file):

add_c_executable(Messenger_test testing/Messenger_test.c)
target_link_modules(Messenger_test toxmessenger toxgroup)

Why toxgroup was added?

Comments from Reviewable

@iphydf
Test a few cmake option combinations before the build.
0a61d11 
This takes a few seconds but allows us to cover cases that aren't checked
often.
@iphydf
Copy link
Member Author

iphydf commented Jan 5, 2017

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

CMakeLists.txt, line 505 at r1 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

Why toxgroup was added?

Removed again. This snuck in from trying to build isotoxin's PR.

Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Jan 5, 2017

:lgtm_strong:

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit 0a61d11 into TokTok:master Jan 5, 2017
@nurupo
Copy link
Member

nurupo commented Jan 13, 2017

:lgtm_strong:

Comments from Reviewable

@iphydf iphydf deleted the test-cmake-combos branch January 21, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Diadlo Diadlo

Labels
None yet
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @Diadlo @nurupo