Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance download paths in the examples notebooks #810

Closed
GeorgeBatch opened this issue Apr 26, 2024 · 2 comments · Fixed by #828
Closed

Enhance download paths in the examples notebooks #810

GeorgeBatch opened this issue Apr 26, 2024 · 2 comments · Fixed by #828

Comments

@GeorgeBatch
Copy link
Contributor

  • TIA Toolbox version: 1.5.1
  • Python version: 3.11.8
  • Operating System: CentOS Linux 7 (Core)

Description

In the example notebooks, the files are sometimes downloaded into the examples directory instead of the examples/tmp/ directory. The examples/tmp/ is the place for downloads since it gets cleared at the start of every notebook.

What I Did

In examples/10-wsi-registration.ipynb I changed:

fixed_img_file_name = Path("fixed_image.tif")
moving_img_file_name = Path("moving_image.tif")

to

fixed_img_file_name = global_save_dir / "fixed_image.tif"
moving_img_file_name = global_save_dir / "moving_image.tif"

I wanted to make a pull request with fixes like that.

Problem: But because of the notebook format, the metadata changes when I save the notebook. Instead of a 2-line change, GitHub sees more than 100 deletions and additions. See: GeorgeBatch@97d65b9

Possible solution: Maybe it's better to have the example notebooks saved without the outputs.

@shaneahmed
Copy link
Member

Please go ahead and create a PR. All the notebooks are written in Colab, so if you write the notebook in Colab the metadata won't change much. You can also review the change in reviewnb. The link for reviewnb should automatically be generated when you create the PR.

@GeorgeBatch
Copy link
Contributor Author

I was running them locally, will try in collab so metadata changes less.

shaneahmed added a commit that referenced this issue Jun 26, 2024
- Enhance Download Paths in `10-wsi-registration.ipynb`
- Fixes #810 

Thanks @GeorgeBatch for raising this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants