HttpHeaders.with should replace existing header #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slutmaker
reviewed
Apr 25, 2023
| var i = 0; | ||
| for (var stringListEntry : this) { | ||
| entries[i++] = stringListEntry; | ||
| Map<String, List<String>> newValues = new HashMap<>(this.size()); |
There was a problem hiding this comment.
new HashMap<>(this.size()) не является корректной initialCapacity, можно подсмотреть реализацию у Maps.newHashMapWithExpectedSize либо оставить массив Map.Entry, просто проверять через equals в цикле stringListEntry.getKey() с key из входных параметров
There was a problem hiding this comment.
а если так переписать:
Map<String, List<String>> newValues = new HashMap<>(this.size() + 1)
There was a problem hiding this comment.
Лучше оставить вариант с entries и доработать проверку по equals, он будет оптимальней
slutmaker
reviewed
Apr 25, 2023
| entries[i++] = stringListEntry; | ||
| Map<String, List<String>> newValues = new HashMap<>(this.size()); | ||
| for (var entry : this) { | ||
| newValues.put(entry.getKey().toLowerCase(), entry.getValue()); |
There was a problem hiding this comment.
lowerCase здесь бтв излишен
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the method HttpHeaders.with causes undefined behavior or an error when adding an existing header, depending on the case of the header name.