feat(android): allow building exoplayer from source #3932
Conversation
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
* fix: ensure player doesn't start when view is unmounted
…ideo into feat/allowBuildingFromExoplayerSource
|
@KrzysztofMoch This one is ready for review ! |
KrzysztofMoch
changed the title
Great, thank you, so let's merge this one ! 👍 |
|
@freeboub |
|
For media3 version, I tried few month ago, I had some issue regarding to gradle plugin. But you can force the version in the gradle file with following value. The react native version used in sample was not compatible with media3... RNVideo_media3Version=1.1.1 Notice also that in my thumbnail poc, I use master branch of media3 so version 1.3.1 shall work (no blocking point on API change). |
|
@freeboub |
|
@YangJonghun I am not sure to understand exactly what you want do ... Upgrading locally to 1.2.0 doesn't ? |
|
@freeboub |
Summary
Add configuration and documentation to be able to build from media3 / Exoplayer source code
Motivation
I had to do a small workaround in exoplayer source code to develop a new feature/poc
Changes
Test plan
Easy to test by change the sample, @KrzysztofMoch do you think I need to enable 1 dedicated build from source in the github CI ? My issue with that is that sample will need to clone media3 source code, it will highly increase folder size for developement environment ...