Create an interface to this ~~script~~ library #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galaxy102
added a commit
to Galaxy102/budgie-bluetooth-battery-applet
that referenced
this pull request
Nov 13, 2021
|
The code is so nice and clean. I tested it and it works very well. I'm going to merge this, but before that, can you provide some instructions on how to use it as a library for people who might be interested in that? |
|
Thank you for the nice comment. I added the instructions to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @TheWeirdDev,
thanks for your work, it gave me a great starting point to develop a Budgie Applet (coming soon) to request my new headset's battery state.
To integrate it more smoothly, I abstracted the C-ish source code into a (I hope at least) more Pythonic interface. The main difference - besides the abstraction in a class - is that nothing outside the
if __name__ == '__main__'can write tostdoutand Errors are raised in a programmatic manner.Please let me know if you request any changes. If you don't want my pseudonym in the source file, I'm open to removing it.
Best regards,
Konstantin (@Galaxy102)